Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding modules for IGMP interface policy object. (DCNE-128) #577

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anvitha-jain
Copy link
Collaborator

No description provided.

@github-actions github-actions bot changed the title Adding modules for IGMP interface and tenant route map policy object. Adding modules for IGMP interface and tenant route map policy object. (DCNE-128) Jan 10, 2025
@anvitha-jain anvitha-jain changed the title Adding modules for IGMP interface and tenant route map policy object. (DCNE-128) Adding modules for IGMP interface policy object. (DCNE-128) Jan 10, 2025
@anvitha-jain anvitha-jain self-assigned this Jan 10, 2025
@anvitha-jain anvitha-jain force-pushed the igmp_interface branch 3 times, most recently from eeb7c0f to 81f2537 Compare January 18, 2025 01:38
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
gmicol
gmicol previously approved these changes Jan 22, 2025
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_igmp_interface_policy.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain requested a review from shrsr January 24, 2025 19:30
- Defaults to C(disabled) when unset during creation.
type: str
choices: [ enabled, disabled ]
aliases: [ allow_version3_asm ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this alias?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI represents this argument as -> "Allow Version 3 ASM". Hence, the alias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for IGMP Interface Policy in Tenant Tenant Policies Template (DCNE-128)
5 participants